Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Modules need updated version of ITK #87

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

hjmjohnson
Copy link
Member

COMP: Modules need updated version of ITK

Removal of .h includes from same named .hxx files
requires removal of outdated rule that is no longer
relevant.

This PR will update the version of ITK that is
used for the remove modules."

BRANCH_NAME=update-reference-itk-version
for remdir_script in *.remote.cmake; do

remdir="${remdir_script//.remote.cmake/}"
if [ ! -d "${remdir}" ] ;then
echo "Missing directory ${remdir}"
continue
fi
pushd "${remdir}" || exit
echo "=============== $(pwd) ========="
git checkout master
git fetch origin
git rebase origin/master
git checkout -b ${BRANCH_NAME}
sed 's/itk-git-tag : .
/itk-git-tag: "a89145bccda6a36f42cfdd45d3a6b27234ff54fe"/g' $( fgrep -Rl "itk-git-tag:" |fgrep yml )

git status
diff_line_no=$(git diff |wc -l )
if [ "${diff_line_no}" -ne 0 ]; then
git add -p
git commit -F /tmp/update_itk_msg

gh pr create -a "@me" -F /tmp/update_itk_msg

else
echo "Skipping changes $(pwd)"
fi
git fetch
git rebase origin/master
git push origin -f ${BRANCH_NAME}:${BRANCH_NAME}

popd || exit
done

Removal of .h includes from same named .hxx files
requires removal of outdated rule that is no longer
relevant.

This PR will update the version of ITK that is
used for the remove modules."

BRANCH_NAME=update-reference-itk-version
for remdir_script in *.remote.cmake; do

  remdir="${remdir_script//*.remote.cmake/}"
  if [ ! -d "${remdir}" ] ;then
    echo "Missing directory ${remdir}"
    continue
  fi
  pushd "${remdir}" || exit
  echo "=============== $(pwd) ========="
  git checkout master
  git fetch origin
  git rebase origin/master
  git checkout -b ${BRANCH_NAME}
  sed 's/itk-git-tag : .*/itk-git-tag: "a89145bccda6a36f42cfdd45d3a6b27234ff54fe"/g' $( fgrep -Rl "itk-git-tag:" |fgrep yml )

  git status
  diff_line_no=$(git diff |wc -l )
  if [ "${diff_line_no}" -ne 0 ]; then
    git add -p
    git commit -F /tmp/update_itk_msg

    gh pr create -a "@me" -F /tmp/update_itk_msg
  else
    echo "Skipping changes $(pwd)"
  fi
  git fetch
  git rebase origin/master
  git push origin -f ${BRANCH_NAME}:${BRANCH_NAME}

  popd || exit
done
@hjmjohnson hjmjohnson self-assigned this Dec 18, 2021
@hjmjohnson hjmjohnson merged commit 8efc307 into master Dec 18, 2021
aylward added a commit to InsightSoftwareConsortium/ITK that referenced this pull request Aug 8, 2022
* ENH: Bump MinimalPathExtraction module to v1.2.2

# Changes

* COMP: Remove inclusion of .hxx files as headers by @hjmjohnson in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#86
* COMP: Modules need updated version of ITK by @hjmjohnson in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#87
* BUG: Set FastMarching targets prior to reach mode by @aylward in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#90
* ENH: Bump ITK and replace http with https using script by @tbirdso in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#89
* ENH: Update Python package for itk-5.3rc4 by @thewtex in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#88
* ENH: Bump ITK to v5.3rc04(.post2) by @aylward in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#93

* @tbirdso made their first contribution in
* InsightSoftwareConsortium/ITKMinimalPathExtraction#89

**Full Changelog**:
InsightSoftwareConsortium/ITKMinimalPathExtraction@v1.2.0...v1.2.1

* ENH: Bump MinimalPathExtraction to v1.2.2

v1.2.1 had a minor bug that would have prevented it from correctly
resolving future versions of ITK

See
https://github.com/InsightSoftwareConsortium/ITKMinimalPathExtraction/releases/tag/v1.2.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant