Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fixes to build process #79

Merged
merged 2 commits into from
Jan 3, 2019
Merged

BUG: Fixes to build process #79

merged 2 commits into from
Jan 3, 2019

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Jan 2, 2019 •
edited
Loading

No description provided.

@dzenanz
BUG: updating test output path to allow testing as part of ITK
b7f43df 
Solving run-time errors of the form:

2752: Padding method 2
2752: Peak interpolation method 0
2752: -0.55 == -0.3 == -0.55
2752: 1.6 == 1.85 == 1.6
2752:
2752: itk::ExceptionObject (0000000A828FE910)
2752: Location: "unknown"
2752: File: C:\Dev\ITK-git\Modules\IO\NRRD\src\itkNrrdImageIO.cxx
2752: Line: 1104
2752: Description: itk::ERROR: NrrdImageIO(000001538FDB7140): Write: Error writing C:/Dev/ITK-2k17/Modules/Remote/Montage/test/../Testing/Temporary/itkMontagePCMTestSynthetic_2cc.nrrd:
2752: [nrrd] nrrdSave: couldn't fopen("C:/Dev/ITK-2k17/Modules/Remote/Montage/test/../Testing/Temporary/itkMontagePCMTestSynthetic_2cc.nrrd","wb"): No such file or directory
@dzenanz dzenanz requested a review from thewtex January 2, 2019 15:45
@dzenanz dzenanz changed the title BUG: updating test output path to allow testing as part of ITK BUG: Fixes to build process Jan 2, 2019
@dzenanz
Copy link
Member Author

dzenanz commented Jan 2, 2019

ci:package is now failing due to internal compiler error 😞:

In file included from ../../../ITK-cp27-cp27m-manylinux1_x64/Wrapping/Typedefs/itkPhaseCorrelationImageRegistrationMethodSwigInterface.h:18:0,
                 from Wrapping/Modules/Montage/itkPhaseCorrelationImageRegistrationMethodPython.cpp:3740:
../../../include/itkPhaseCorrelationImageRegistrationMethod.h: In instantiation of ‘struct itk::PhaseCorrelationImageRegistrationMethod<itk::Image<float, 2u>, itk::Image<float, 2u> >::__lambda13’:
../../../include/itkPhaseCorrelationImageRegistrationMethod.hxx:62:111:   required from ‘itk::PhaseCorrelationImageRegistrationMethod<TFixedImage, TMovingImage>::PhaseCorrelationImageRegistrationMethod() [with TFixedImage = itk::Image<float, 2u>; TMovingImage = itk::Image<float, 2u>]’
../../../include/itkPhaseCorrelationImageRegistrationMethod.h:116:3:   required from ‘static itk::PhaseCorrelationImageRegistrationMethod<TFixedImage, TMovingImage>::Pointer itk::PhaseCorrelationImageRegistrationMethod<TFixedImage, TMovingImage>::New() [with TFixedImage = itk::Image<float, 2u>; TMovingImage = itk::Image<float, 2u>; itk::PhaseCorrelationImageRegistrationMethod<TFixedImage, TMovingImage>::Pointer = itk::SmartPointer<itk::PhaseCorrelationImageRegistrationMethod<itk::Image<float, 2u>, itk::Image<float, 2u> > >]’
Wrapping/Modules/Montage/itkPhaseCorrelationImageRegistrationMethodPython.cpp:5972:66:   required from here
../../../include/itkPhaseCorrelationImageRegistrationMethod.h:382:51: internal compiler error: in tsubst_copy, at cp/pt.c:12116
   const FrequencyFunctorType m_BandPassFunctor = [this]( typename BandBassFilterType::FrequencyIteratorType& freqIt )
                                                   ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugzilla.redhat.com/bugzilla> for instructions.
Preprocessed source stored into /tmp/ccftnrNC.out file, please attach this to your bugreport.

@thewtex thewtex merged commit d0994e6 into InsightSoftwareConsortium:master Jan 3, 2019
dzenanz added a commit to dzenanz/ITKMontage that referenced this pull request Oct 14, 2019
@dzenanz
ENH: add calculation of systematic translation bias to pair-wise test
5a2535d 
Also enable pair-wise test for all ground truth tests.

Summary results (below) suggest presence of bias in sub-pixel peak estimation:

PeakInterpolation 0 has average translation bias: -0.040 -0.028
PeakInterpolation 1 has average translation bias: -0.035 -0.025
PeakInterpolation 2 has average translation bias: -0.038 -0.027
Average translation error for padding method 2: 0.194
Test InsightSoftwareConsortium#52: itkMontageGroundTruthRun10-129 ..............***Failed    2.33 sec

PeakInterpolation 0 has average translation bias: -0.011 -0.017
PeakInterpolation 1 has average translation bias: -0.009 -0.014
PeakInterpolation 2 has average translation bias: -0.010 -0.016
Average translation error for padding method 2: 0.162
Test InsightSoftwareConsortium#54: itkMontageGroundTruthRunrun2 ................   Passed    1.58 sec

PeakInterpolation 0 has average translation bias: 0.021 -0.010
PeakInterpolation 1 has average translation bias: 0.019 -0.009
PeakInterpolation 2 has average translation bias: 0.020 -0.010
Average translation error for padding method 2: 0.172
Test InsightSoftwareConsortium#56: itkMontageGroundTruthRunMediumCarbonSteel ...***Failed    3.49 sec

PeakInterpolation 0 has average translation bias: 0.104 0.303 -0.040
PeakInterpolation 1 has average translation bias: 0.104 0.302 -0.041
PeakInterpolation 2 has average translation bias: 0.104 0.303 -0.041
Average translation error for padding method 2: 0.306
Test InsightSoftwareConsortium#70: itkMontageGroundTruthRunDzZ_T1 ..............***Failed   19.56 sec

PeakInterpolation 0 has average translation bias: 1.065 1.733
PeakInterpolation 1 has average translation bias: 1.066 1.734
PeakInterpolation 2 has average translation bias: 1.065 1.733
Average translation error for padding method 2: 1.811
Test InsightSoftwareConsortium#79: itkMontageGroundTruthRunTiles ...............***Failed   10.31 sec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzenanz @thewtex