ENH: We now always depend on numpy, so specify that in setup.py #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's hold off on merging this until numpy/numpy#17807 is addressed. |
|
With the latest macOS, pip, numpy 1.20.2 will now build from source, so this is good enough. |
thewtex
reviewed
May 4, 2021
setup.py
Outdated
| @@ -70,5 +70,6 @@ | |||
| keywords='ITK InsightToolkit segmentation registration image imaging', | |||
| url=r'https://itk.org/', | |||
| install_requires=[ | |||
| r'numpy>=1.20', | |||
There was a problem hiding this comment.
I'll follow-up, but we made sure that the typing support that we use in numpy is optional for systems that also want tensorflow.
thewtex
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we need numpy 1.20 for typing, which in turn requires Python 3.7+. Should we also add a note to main ITK repo that Python 3.6 is no longer supported?