Pass option to setup.py and cmake on Windows, clean-up and avoid unnecessary downloads #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 4, 2023 14:44
This can occur if the same machine is used twice, e.g., a self-hosted runner.
This was already the case in Linux scripts since 0ea5af0.
dzenanz
approved these changes
Jan 6, 2023
tbirdso
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
@SimonRit Looks great, thank you for contributing!
It looks like the referenced RTK windows-cuda-python-packages job has completed successfully. The logs show that the RTK_CUDA_VERSION argument is passed appropriately to CMake.
I will wait a bit for @LucasGandel to have a look as well before merge.
LucasGandel
reviewed
Jan 10, 2023
LucasGandel
approved these changes
Jan 11, 2023
LucasGandel
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 3 commits are used to allow (and improve) RTK compilation with CUDA following the latest developments of ITKRemoteModuleBuildTestPackageAction, see RTKConsortium/RTK#526. I haven't worked on specific options for each itk-module-deps (yet, I'm not sure it will be required for RTKConsortium/RTK#492)...