Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass option to setup.py and cmake on Windows, clean-up and avoid unnecessary downloads #248

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Pass option to setup.py and cmake on Windows, clean-up and avoid unnecessary downloads #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dca3c8
ENH: Pass setup.py and cmake options in PowerShell module script
Jan 3, 2023
a3a2311
ENH: Clean-up existing ITKPythonBuilds-windows.zip extraction
Jan 5, 2023
6a72964
ENH: Only download zip/zst files if they are not already available
Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/macpython-download-cache-and-build-module-wheels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ brew upgrade cmake

# Fetch ITKPythonBuilds archive containing ITK build artifacts
echo "Fetching https://github.com/InsightSoftwareConsortium/ITKPythonBuilds/releases/download/${ITK_PACKAGE_VERSION:=v5.3.0}/ITKPythonBuilds-macosx.tar.zst"
aria2c -c --file-allocation=none -o ITKPythonBuilds-macosx.tar.zst -s 10 -x 10 https://github.com/InsightSoftwareConsortium/ITKPythonBuilds/releases/download/${ITK_PACKAGE_VERSION:=v5.3.0}/ITKPythonBuilds-macosx.tar.zst
if [[ ! -f ITKPythonBuilds-macosx.tar.zst ]]; then
aria2c -c --file-allocation=none -o ITKPythonBuilds-macosx.tar.zst -s 10 -x 10 https://github.com/InsightSoftwareConsortium/ITKPythonBuilds/releases/download/${ITK_PACKAGE_VERSION:=v5.3.0}/ITKPythonBuilds-macosx.tar.zst
fi
unzstd --long=31 ITKPythonBuilds-macosx.tar.zst -o ITKPythonBuilds-macosx.tar
PATH="/usr/local/opt/gnu-tar/libexec/gnubin:$PATH"
tar xf ITKPythonBuilds-macosx.tar --checkpoint=10000 --checkpoint-action=dot
Expand Down
32 changes: 28 additions & 4 deletions scripts/windows-download-cache-and-build-module-wheels.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@
#
# > windows-download-cache-and-build-module-wheels.ps1 11
#
# - other parameters are passed to setup.py. If one of the parameters is "--",
# the following parameters will be passed to cmake.
# For instance, for Python 3.11, excluding nvcuda.dll during packaging
# and setting RTK_USE_CUDA ON during configuration:
#
# > windows-download-cache-and-build-module-wheels.ps1 11 --exclude-libs nvcuda.dll "--" -DRTK_USE_CUDA:BOOL=ON
tbirdso marked this conversation as resolved.
Show resolved Hide resolved
#
#
# -----------------------------------------------------------------------
# Environment variables used in this script:
#
Expand All @@ -37,7 +45,12 @@ iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.co

if (-not $env:ITK_PACKAGE_VERSION) { $env:ITK_PACKAGE_VERSION = 'v5.3.0' }
echo "Fetching build archive $env:ITK_PACKAGE_VERSION"
Invoke-WebRequest -Uri "https://github.com/InsightSoftwareConsortium/ITKPythonBuilds/releases/download/$env:ITK_PACKAGE_VERSION/ITKPythonBuilds-windows.zip" -OutFile "ITKPythonBuilds-windows.zip"
if (Test-Path C:\P) {
Remove-Item -Recurse -Force C:\P
}
if (-not (Test-Path ITKPythonBuilds-windows.zip)) {
Invoke-WebRequest -Uri "https://github.com/InsightSoftwareConsortium/ITKPythonBuilds/releases/download/$env:ITK_PACKAGE_VERSION/ITKPythonBuilds-windows.zip" -OutFile "ITKPythonBuilds-windows.zip"
}
7z x ITKPythonBuilds-windows.zip -oC:\P -aoa -r

# Optional: Update ITKPythonPackage build scripts
Expand All @@ -63,15 +76,26 @@ if ($env:ITKPYTHONPACKAGE_TAG) {
}

# Get other build dependencies
Invoke-WebRequest -Uri "https://data.kitware.com/api/v1/file/5c0ad59d8d777f2179dd3e9c/download" -OutFile "doxygen-1.8.11.windows.bin.zip"
if (-not (Test-Path doxygen-1.8.11.windows.bin.zip)) {
Invoke-WebRequest -Uri "https://data.kitware.com/api/v1/file/5c0ad59d8d777f2179dd3e9c/download" -OutFile "doxygen-1.8.11.windows.bin.zip"
}
7z x doxygen-1.8.11.windows.bin.zip -oC:\P\doxygen -aoa -r
Invoke-WebRequest -Uri "https://data.kitware.com/api/v1/file/5bbf87ba8d777f06b91f27d6/download/grep-win.zip" -OutFile "grep-win.zip"
if (-not (Test-Path grep-win.zip)) {
Invoke-WebRequest -Uri "https://data.kitware.com/api/v1/file/5bbf87ba8d777f06b91f27d6/download/grep-win.zip" -OutFile "grep-win.zip"
}
7z x grep-win.zip -oC:\P\grep -aoa -r
$env:Path += ";C:\P\grep"

# Build ITK module dependencies, if any
$build_command = "& `"C:\Python$pythonVersion-x$pythonArch\python.exe`" `"C:\P\IPP\scripts\windows_build_module_wheels.py`" --no-cleanup --py-envs `"3$($args[0])-x64`""
echo "Build command: $build_command"
foreach ($arg in $args[1..$args.length]) {
if ($arg.substring(0,2) -eq "--") {
$build_command = "$build_command $($arg)"
tbirdso marked this conversation as resolved.
Show resolved Hide resolved
}
else {
$build_command = "$build_command `"$($arg)`""
}
}

echo "ITK_MODULE_PREQ: $env:ITK_MODULE_PREQ $ITK_MODULE_PREQ"
if ($env:ITK_MODULE_PREQ) {
Expand Down