Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Versions as strings, not numbers, so that 3.1 != 3.10, etc. #8

Merged

Conversation

Leengit
Copy link
Contributor

@Leengit Leengit commented Nov 3, 2022

Write versions as strings rather than numbers because 3.1 != 3.10, etc. Nothing is broken at present but in the future as, e.g., the Python version for some things goes from 3.8 to 3.9 to 3.10, this could end up being an unexpected problem.

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leengit thank you!! 🙏

@thewtex thewtex merged commit bf603c0 into InsightSoftwareConsortium:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants