Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: VTK Superbuild Update #193

Merged
merged 5 commits into from
Feb 24, 2021
Merged

ENH: VTK Superbuild Update #193

merged 5 commits into from
Feb 24, 2021

Commits on Feb 23, 2021

  1. ENH: Bump VTK version to 9.0.1 in Superbuild

    @mseng10
    mseng10 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    b96567d View commit details
    Browse the repository at this point in the history

  2. BUG: Specify version for LevelSetV4Visualization examples 

    These examples only compile with ITK 4.13 and below as they incorporate the ITKLevelSetV4Visualization module. This modules was moved in ITK 5.0.
    @mseng10
    mseng10 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    1ed5ce9 View commit details
    Browse the repository at this point in the history

  3. ENH: Allow examples to be built without QuickView 

    Presently, all of the examples that utilize QuickView are disabled if
QuickView is not enabled. However, these examples strictly use QuickView
for visualization purposes and don't contribute to the core
functionality of the program.

These changes primarily change 2 types of CMakeList.txt files: the ones
for a module and those for a specific example.

For modules, it will remove if(ENABLE_QUICKVIEW) to simply just enable
the example. If some of the examples strictly used VTK and not
QuickView, I replaced it with if(VTK_DIR).

For examples, it will first check if QuickView is enabled. If so, that
will find the VTK package and only utilize the components we need which
primarily is: vtkRenderingCore and vtkRenderingGL2PSOpenGL2. If the VTK
version is less than 8.9, then the VTK_USE_FILE is included. Finally, it
links the VTK_LIBRARIES, and intiates the VTK module if the VTK version is atleast 8.9.
    @mseng10
    mseng10 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    f30851e View commit details
    Browse the repository at this point in the history

  4. ENH: Configure examples that utilize VTK 

    Many of the examples that utilize VTK were not configured correctly or
needed to be updated to accomodate VTK 9.1.0.

This primarily included, finding the VTK package and only using the
components that specific example needed. If the VTK version is less than
8.9, then the VTK_USE_FILE is included. Finally, the VTK_LIBRARIES are
linked and if the VTK version is atleast 8.9, then the module is
inialized using VTK's vtk_module_autoinit().
    @mseng10
    mseng10 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    f079817 View commit details
    Browse the repository at this point in the history

  5. BUG: Fix input for examples that use VTK 

    After fixing the CMakeList.txt scipts for examples that use VTK library
in some form, many of the examples needed there test input and
documentation updated.

This primarily added an input image for an examples test, and updated
it's respective documentation.txt with the input and output.

A few of the examples and/or their respective tests contained errors
that were marked with a TODO, for a future PR. These included:
  1) Baseline comparisons, that cannot work due to the output not ever
     being stored. In a future PR, the examples should be modified to
     save their output, so we can test against it.
       + VTKImageToITKImageBaseline
       + InPlaceFilterOfImageBaseline
       + GeometricPropertiesOfRegionBaseline
  2) The DemonstrateThresholdAlgorithm example has it's
     KittlerIllingworth filter commented out with a TODO. This was the
     only filter to not work, and will be documented in a future issue.
    @mseng10
    mseng10 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    cddc856 View commit details
    Browse the repository at this point in the history