feat: support network logs obfuscation #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7medev
changed the title
abdelhamid-f-nasser
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Great job @a7medev 👏 . The code is well written and quite descriptive. Just a suggestion for adding docs to obfuscateLog API.
There was a problem hiding this comment.
Great job @a7medev 👏 . The code is well written and quite descriptive. Just a suggestion for adding docs to obfuscateLog API.
a7medev
force-pushed
the
feat/network-obfuscation
branch
from
61244bb
to
20ca536
Compare
abdelhamid-f-nasser
approved these changes
Sep 10, 2023
Add docs to obfuscateLog in network_manager.dart
a7medev
force-pushed
the
feat/network-obfuscation
branch
from
d0d6ef0
to
96b7e1c
Compare
ymabdallah
pushed a commit
that referenced
this pull request
Sep 14, 2023
* [MOB-12516] Fix zone mismatch issue (#376) * fix(initialization): fix zone mismatch issue in initialization code * fix(initilization): fix the PR comments * [MOB-12700] Remove danger ruby package (#379) Remove danger ruby package to resolve dependabot git security vulnerability issue. * [MOB-12513] Fix Mockito and Pigeon Dependency Conflict (#377) * Unrestrict a specific Pigeon version * Unrestrict a specific Mockito version * Upgrade Flutter CI version with Mockito and Pigeon * Remove ask question button in example --------- Co-authored-by: Ahmed Mahmoud <a7med.mahmoud2004@gmail.com> * test: update captain config (#386) Jira ID: MOB-13002 * chore(ios): bump sdk to 11.14.0 (#383) Jira ID: MOB-12993 * feat: support network logs obfuscation (#380) Jira ID: MOB-12523 * feat: support network logs omission (#382) Jira ID: MOB-12524 * chore(android): bump sdk to 11.14.0 (#384) Jira ID: MOB-12992 * feat: add new repro steps api (#388) Jira ID: MOB-13005 * chore: update sdk version to v11.14.0 (#389) Jira ID: MOB-13014 --------- Co-authored-by: Ahmed Sami <ahmed.sami.elsherif@gmail.com> Co-authored-by: Ahmed Mahmoud <a7med.mahmoud2004@gmail.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add network logs obfuscation support through the new
NetworkLogger.obfuscateLogAPI.Type of change
Related issues
Jira ID: MOB-12523
Checklists
Development
Code review