Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new repro steps api #388

Merged
merged 12 commits into from Sep 13, 2023
Merged

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Sep 11, 2023

Description of the change

Add support for the new Instabug.setReproStepsConfig API and deprecate the old Instabug.setReproStepsMode.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13005

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Sep 11, 2023
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 11, 2023

Coverage Report

Label Coverage Status
Dart 84.6%

Generated by 🚫 dangerJS against 72e2583

@a7medev a7medev marked this pull request as ready for review September 11, 2023 14:29
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a7medev On point PR 💪 🚀 !

Just one suggestion for docs. Please review it and let me know.

lib/src/modules/instabug.dart Outdated Show resolved Hide resolved
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feat/add-repro-steps-api branch 4 times, most recently from 8da3cf0 to 39b6a2f Compare September 11, 2023 16:44
Copy link
Contributor

@asamiz asamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done my friend @a7medev, this is an approval from my side

@abdelhamid-f-nasser abdelhamid-f-nasser merged commit 000d626 into dev Sep 13, 2023
10 checks passed
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the feat/add-repro-steps-api branch September 13, 2023 14:57
ymabdallah pushed a commit that referenced this pull request Sep 14, 2023
* [MOB-12516] Fix zone mismatch issue (#376)

* fix(initialization): fix zone mismatch issue in initialization code

* fix(initilization): fix the PR comments

* [MOB-12700] Remove danger ruby package (#379)

Remove danger ruby package to resolve dependabot git security vulnerability issue.

* [MOB-12513] Fix Mockito and Pigeon Dependency Conflict (#377)

* Unrestrict a specific Pigeon version

* Unrestrict a specific Mockito version

* Upgrade Flutter CI version with Mockito and Pigeon

* Remove ask question button in example

---------

Co-authored-by: Ahmed Mahmoud <a7med.mahmoud2004@gmail.com>

* test: update captain config (#386)

Jira ID: MOB-13002

* chore(ios): bump sdk to 11.14.0 (#383)

Jira ID: MOB-12993

* feat: support network logs obfuscation (#380)

Jira ID: MOB-12523

* feat: support network logs omission (#382)

Jira ID: MOB-12524

* chore(android): bump sdk to 11.14.0 (#384)

Jira ID: MOB-12992

* feat: add new repro steps api (#388)

Jira ID: MOB-13005

* chore: update sdk version to v11.14.0 (#389)

Jira ID: MOB-13014

---------

Co-authored-by: Ahmed Sami <ahmed.sami.elsherif@gmail.com>
Co-authored-by: Ahmed Mahmoud <a7med.mahmoud2004@gmail.com>
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
HeshamMegid pushed a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants