Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-11946] Delegate Native SDKs #919

Merged
merged 1 commit into from
Feb 20, 2023
Merged

[MOB-11946] Delegate Native SDKs #919

merged 1 commit into from
Feb 20, 2023

Conversation

TheBuggedYRN
Copy link
Contributor

@TheBuggedYRN TheBuggedYRN commented Feb 16, 2023 •
edited
Loading

Description of the change

Allow native apps that have recently integrated React Native within their apps to use Instabug native SDKs via the instabug-reactnative npm package as follows:

Android (app/build.gradle)

apply from: "../../node_modules/instabug-reactnative/android/native.gradle"

iOS (Podfile)

require_relative '../node_modules/instabug-reactnative/ios/native'

target 'CoolApp' do
  use_instabug!
  // ...
end

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@TheBuggedYRN TheBuggedYRN self-assigned this Feb 16, 2023
@TheBuggedYRN TheBuggedYRN force-pushed the refactor/delegate-native-sdks branch 5 times, most recently from 906c2b8 to 60c42d3 Compare February 20, 2023 09:14
@TheBuggedYRN TheBuggedYRN marked this pull request as ready for review February 20, 2023 09:51
@TheBuggedYRN TheBuggedYRN changed the title Delegate Native SDKs [MOB-11946] Delegate Native SDKs Feb 20, 2023
@TheBuggedYRN TheBuggedYRN merged commit 4b658c4 into dev Feb 20, 2023
@TheBuggedYRN TheBuggedYRN deleted the refactor/delegate-native-sdks branch February 20, 2023 12:03
TheBuggedYRN added a commit that referenced this pull request Feb 20, 2023
@TheBuggedYRN
[MOB-11946] Delegate Native SDKs (#919)
a293904 
Allow native apps that have recently integrated React Native
within their apps to use Instabug native SDKs via the
`instabug-reactnative` npm package.
ymabdallah pushed a commit that referenced this pull request Feb 20, 2023
@TheBuggedYRN @ymabdallah
[MOB-11946] Delegate Native SDKs (#919)
f7d5d15 
Allow native apps that have recently integrated React Native
within their apps to use Instabug native SDKs via the
`instabug-reactnative` npm package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMina96 DavidMina96 DavidMina96 approved these changes

@a7medev a7medev a7medev approved these changes

Assignees

@TheBuggedYRN TheBuggedYRN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheBuggedYRN @DavidMina96 @a7medev