PoolTogether connector

[eccheung4]

Pool Together Connector that will allow DSA to:

• depositTo : Deposit into a Prize Pool
• withdrawInstantlyFrom: Withdraw from a Prize Pool
• claim: Claim from a token faucet
• claimAll: Claim from multiple token faucet
• depositToPod: Deposit into a Pod
• withdrawFromPod: Withdraw shares from Pod

Should also be able to use Uniswap V2 POOL/ETH LP to deposit into PoolTogether Uniswap POOL LP Prize Pool

[thrilok209]

@eccheung4 Can you attach poolTogether docs about the integration?

Also, what does the "claim from a token faucet" function do exactly? Why is it used?

[eccheung4]

@thrilok209 Hope these are what you are looking for.

• Smart Contract Guidelines: https://docs.pooltogether.com/contributing/smart-contract-guidelines
• Prize Pools: https://docs.pooltogether.com/protocol/prize-pool
• Token Faucet: https://docs.pooltogether.com/tutorials/add-a-token-faucet

The Token Faucet is Pool Together's mechanism for distributing tokens to user's for joining a Prize Pool. It is an extra incentive for joining a Prize Pool. The Token Faucet drips a certain number of tokens per second. Those tokens are distributed to users based on their balance of measure tokens held. The claim function is used to claim the user's reward from a token faucet.

[eccheung4]

@thrilok209 I'm done with edits, let me know if you need anything else when reviewing.

[thrilok209]

@eccheung4 Awesome! We will start reviewing the pr.

[thrilok209]

@eccheung4 Added some suggestions.

[thrilok209]

Hey @eccheung4! We would also need a resolver contract. That is used to fetch protocol and connector functions related data. Resolver helps simplify reading operations on our frontend interfaces.

https://github.com/Instadapp/dsa-resolvers
https://www.notion.so/instadapp/Instadapp-Protocol-Integration-d14f34f1a4aa42138154143948ddb7b4

Eg: Compound resolver- https://github.com/Instadapp/dsa-resolvers/tree/main/contracts/protocols/mainnet/compound

[eccheung4]

@thrilok209 wow, thanks for the quick review! Cool, will look into resolver contract. Sorry, didn't know that was needed as well.

[eccheung4]

@thrilok209 I believe I've implemented all your suggestions. I'll start on the resolver next.

[eccheung4]

@thrilok209 I've submitted PR for resolver and a fix for uniswapStaking. Thanks!

[thrilok209]

@eccheung4 Connector looks good!

Next would be deploying the connector and then adding it to the ConnectorsV2 registry. Could you deploy the connector and comment the deployed connector address in this pr? :)

[eccheung4]

@thrilok209 Deployed Connector

ConnectorName: "POOLTOGETHER-A"
ConnectorAddress: 0xbf254fA556703c78d70B4Cec8459d1Ff2b33Cd87

[thrilok209]

Connector whitelisted: https://etherscan.io/tx/0x1c6632f575670c0dcee1cb0230c3f2d5c5f5e0a58bfd5eec270692faabeb809e