fix: fixed test:runner for multiple blockchain #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the last merged PR is that we have used
network.nameto segregate the blockchain network.But it always gives
hardhatas its network type. Hence all tests other thanmainnetwill again fail.So, this PR tries another way to fix that bug by dynamically providing URL to hardhat.config by using the command line, which changes the
process.envvariable accordingly.I have also added arbitrum and polygon mainnet forking URLs for future references in the config file and minor changes to
.env.example.This PR also added a global test running script integrated with the
npm run testcommand.You only have to use one command to run all tests of different blockchains; the script will automatically change the config.