Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test rules in pyflakes directory #271

Open
wants to merge 2 commits into
base: gh/"ansley"/1/base
Choose a base branch
from
Open

Test rules in pyflakes directory #271

wants to merge 2 commits into from

Conversation

ansley
Copy link

@ansley ansley commented Mar 8, 2023 •
edited

This was referenced Mar 8, 2023
Open
Open
Open
Open
Open
Open
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 8, 2023
amyreese
amyreese requested changes Mar 8, 2023
View reviewed changes
pyproject.toml
@@ -72,7 +72,7 @@ version-file = "src/fixit/__version__.py"
features = ["dev", "pretty"]

[tool.hatch.envs.default.scripts]
test = "python -m fixit.tests"
test = "python3 -m fixit.tests"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change needed? Hatch environments should be controlled enough that just python will always work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, didn't know that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this being "python3" is what's causing the CI failures on windows. My guess is that the virtualenv doesn't have a python3.exe in it, and so it's finding a random non-venv runtime, and therefore can't find/import fixit.

src/fixit/tests/__init__.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyreese amyreese amyreese requested changes

@zsol zsol Awaiting requested review from zsol zsol is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. lint rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ansley @amyreese @facebook-github-bot