[F811] Warn on and delete double import #275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 8, 2023
[ghstack-poisoned]
amyreese
requested changes
Mar 17, 2023
Comment on lines
+197
to
+199
| expected_replacement=""" | ||
| import a | ||
| """, |
There was a problem hiding this comment.
For these shadowed imports, this autofix is incorrect — it will result in different runtime behavior than what the original code was, because the last import of a name overwrites all previous imports of that name.
If we can't get that right, then we need to skip the autofix, or defer this rule until a future time when we can do it correctly.
Comment on lines
+176
to
+177
| import a, b | ||
| """, |
There was a problem hiding this comment.
I know in this case, both a imports are referring to the same module, but I don't like the idea that we're removing the second import. We should instead be removing the first one, so that we're giving consistent runtime behavior before/after. For imports with side-effects, order unfortunately matters.
Comment on lines
+185
to
+186
| import a, b | ||
| """, |
Comment on lines
+207
to
+208
| from x import a | ||
| """, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
pyflakesdirectory #271