Fix the podlint error #1428
Closed
Fix the podlint error #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D20036436 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D20036436 |
lorixx
added a commit
to lorixx/IGListKit
that referenced
this pull request
Feb 26, 2020
Summary: Pull Request resolved: Instagram#1428 We kept getting an error as the following: ``` - ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.11) is not compatible with `IGListSwiftKit (4.1.0)`, which does not support `macOS`.) during validation. ``` Looks like IGListSwiftKit did not support macos, wondering why this is the case here. Potentially this error was introduced in this PR: Instagram#1388 cc natestedman who might know the context here Differential Revision: D20036436 fbshipit-source-id: dc77dfae335420fe310ad39a662753af831a1054
lorixx
force-pushed
the
export-D20036436
branch
from
2ae9e6a
to
6ac15a5
Compare
lorixx
added a commit
to lorixx/IGListKit
that referenced
this pull request
Feb 26, 2020
Summary: Pull Request resolved: Instagram#1428 We kept getting an error as the following: ``` - ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.11) is not compatible with `IGListSwiftKit (4.1.0)`, which does not support `macOS`.) during validation. ``` Looks like IGListSwiftKit did not support macos, wondering why this is the case here. Potentially this error was introduced in this PR: Instagram#1388 cc natestedman who might know the context here Reviewed By: natestedman Differential Revision: D20036436 fbshipit-source-id: e9344c847c4be837bc43306a3128ffc87246efd5
lorixx
force-pushed
the
export-D20036436
branch
from
6ac15a5
to
11f7ea5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D20036436 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D20036436 |
lorixx
added a commit
to lorixx/IGListKit
that referenced
this pull request
Feb 26, 2020
Summary: Pull Request resolved: Instagram#1428 We kept getting an error as the following: ``` - ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.11) is not compatible with `IGListSwiftKit (4.1.0)`, which does not support `macOS`.) during validation. ``` Looks like IGListSwiftKit did not support macos, wondering why this is the case here. Potentially this error was introduced in this PR: Instagram#1388 cc natestedman who might know the context here The solution here is to lint the specs separately in travis, so that for IGListSwiftKit we only lint against ios and tvos. And the other podspecs will still lint against on all platform, including the macos. Reviewed By: natestedman Differential Revision: D20036436 fbshipit-source-id: a2567e439f53593639bff949207af87ff42f6507
lorixx
force-pushed
the
export-D20036436
branch
from
11f7ea5
to
98dbc50
Compare
Summary: Pull Request resolved: Instagram#1428 We kept getting an error as the following: ``` - ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.11) is not compatible with `IGListSwiftKit (4.1.0)`, which does not support `macOS`.) during validation. ``` Looks like IGListSwiftKit did not support macos, wondering why this is the case here. Potentially this error was introduced in this PR: Instagram#1388 cc natestedman who might know the context here The solution here is to lint the specs separately in travis, so that for IGListSwiftKit we only lint against ios and tvos. And the other podspecs will still lint against on all platform, including the macos. Reviewed By: natestedman Differential Revision: D20036436 fbshipit-source-id: 67c1578779a20435af0c43428c40a38ad18265b3
lorixx
force-pushed
the
export-D20036436
branch
from
98dbc50
to
38fffaa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D20036436 |
4 tasks
|
This pull request has been merged in 884b97d. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We kept getting an error as the following:
Looks like IGListSwiftKit did not support macos, wondering why this is the case here.
Potentially this error was introduced in this PR: #1388
cc natestedman who might know the context here
Differential Revision: D20036436