Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Catches 502 and 504 errors. #70

Merged

Conversation

philnash
Copy link
Contributor

@philnash philnash commented May 3, 2013

On occasion I have experienced Faraday::Error::ParsingError errors from the
gem because they are not caught in the HTTP Exception middleware. They then
fall through to the JSON parser, but since it is returning HTML from nginx
the parser throws an error instead.

I have added the extra errors and tests that include the HTML returned to
ensure that the middleware catches the errors before the JSON parser sees
them.

On occasion I have experienced Faraday::Error::ParsingError errors from the
gem because they are not caught in the HTTP Exception middleware. They then
fall through to the JSON parser, but since it is returning HTML from nginx
the parser throws an error instead.

I have added the extra errors and tests that include the HTML returned to
ensure that the middleware catches the errors before the JSON parser sees
them.
@philnash
Copy link
Contributor Author

philnash commented May 3, 2013

Should fix #43 and #44

@yaauie
Copy link
Contributor

yaauie commented Jun 26, 2013

👍

@heatonjb heatonjb merged commit b48cf92 into facebookarchive:master Mar 24, 2014
@philnash
Copy link
Contributor Author

😄

@heatonjb
Copy link
Contributor

I'm aiming for a new v1.0.0 release this week to include a whole bunch of
the outstanding pull requests.

Thanks for your contribution.

Best

Jon

On 24 March 2014 11:40, Phil Nash notifications@github.com wrote:

[image: 😄]

Reply to this email directly or view it on GitHubhttps://github.com//pull/70#issuecomment-38434621
.


J Heaton
07545765521

@heatonjb
Copy link
Contributor

Hi Phil,

IG needs you to complete a Contributor License Agreement (CLA) for your
pull request

http://developers.facebook.com/opensource/cla

Thanks

Jon

On 24 March 2014 11:40, Phil Nash notifications@github.com wrote:

[image: 😄]

Reply to this email directly or view it on GitHubhttps://github.com//pull/70#issuecomment-38434621
.


J Heaton
07545765521

@philnash
Copy link
Contributor Author

Done. Might be worth updating the README or adding a CONTRIBUTING file with this information in, so that contributors know about this up front.

Thanks

@heatonjb
Copy link
Contributor

Thanks. Yeah will do, i think this is something new.

On 25 March 2014 17:05, Phil Nash notifications@github.com wrote:

Done. Might be worth updating the README or adding a CONTRIBUTING file
with this information in, so that contributors know about this up front.

Thanks

Reply to this email directly or view it on GitHubhttps://github.com//pull/70#issuecomment-38592033
.


J Heaton
07545765521

@heatonjb
Copy link
Contributor

Hey Phil,

Are you working on Instagram for work at the moment? I notice you work for
Mint Digital. We're looking at engaging a lot more with companies who are
trying to innovate on the IG platform.

I'm actually based at FB/Instagram in London, might be worth a quick chat.

Best

Jon

On 26 March 2014 11:20, Jonathan Heaton jonathan.heaton@gmail.com wrote:

Thanks. Yeah will do, i think this is something new.

On 25 March 2014 17:05, Phil Nash notifications@github.com wrote:

Done. Might be worth updating the README or adding a CONTRIBUTING file
with this information in, so that contributors know about this up front.

Thanks

Reply to this email directly or view it on GitHubhttps://github.com//pull/70#issuecomment-38592033
.


J Heaton
07545765521


J Heaton
07545765521

@philnash
Copy link
Contributor Author

Hey Jon,

We are certainly working with Instagram fairly regularly, it would definitely be worth a chat. Can you drop me an email on phil@mintdigital.com and we'll sort something out?

Phil

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants