-
Notifications
You must be signed in to change notification settings - Fork 627
Catches 502 and 504 errors. #70
Catches 502 and 504 errors. #70
Conversation
On occasion I have experienced Faraday::Error::ParsingError errors from the gem because they are not caught in the HTTP Exception middleware. They then fall through to the JSON parser, but since it is returning HTML from nginx the parser throws an error instead. I have added the extra errors and tests that include the HTML returned to ensure that the middleware catches the errors before the JSON parser sees them.
Should fix #43 and #44 |
👍 |
😄 |
I'm aiming for a new v1.0.0 release this week to include a whole bunch of Thanks for your contribution. Best Jon On 24 March 2014 11:40, Phil Nash notifications@github.com wrote:
J Heaton |
Hi Phil, IG needs you to complete a Contributor License Agreement (CLA) for your http://developers.facebook.com/opensource/cla Thanks Jon On 24 March 2014 11:40, Phil Nash notifications@github.com wrote:
J Heaton |
Done. Might be worth updating the README or adding a CONTRIBUTING file with this information in, so that contributors know about this up front. Thanks |
Thanks. Yeah will do, i think this is something new. On 25 March 2014 17:05, Phil Nash notifications@github.com wrote:
J Heaton |
Hey Phil, Are you working on Instagram for work at the moment? I notice you work for I'm actually based at FB/Instagram in London, might be worth a quick chat. Best Jon On 26 March 2014 11:20, Jonathan Heaton jonathan.heaton@gmail.com wrote:
J Heaton |
Hey Jon, We are certainly working with Instagram fairly regularly, it would definitely be worth a chat. Can you drop me an email on phil@mintdigital.com and we'll sort something out? Phil |
On occasion I have experienced
Faraday::Error::ParsingError
errors from thegem because they are not caught in the HTTP Exception middleware. They then
fall through to the JSON parser, but since it is returning HTML from nginx
the parser throws an error instead.
I have added the extra errors and tests that include the HTML returned to
ensure that the middleware catches the errors before the JSON parser sees
them.