Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update label: citrixworkspace (versioning fix) #1029

Merged
merged 2 commits into from
May 26, 2023
Merged

Update label: citrixworkspace (versioning fix) #1029

merged 2 commits into from
May 26, 2023

Conversation

duderin0
Copy link
Contributor

@duderin0 duderin0 commented May 3, 2023

appNewVersion was no longer working. It seems Citrix removed the colon after "Version" at some point.

However, this output gave a result like "23.04.0.36 (2304)", which the ending parenthesis is a shortened version of the first two sets in the version number and was not needed, so edited the cut to only include the useful part.

Added versionKey as well to match that full version number, rather than using the shorter and slightly less precise triple version number.

Results when fully up to date version is already installed:

admin in ~/Documents/GitHub/Installomator on CitrixWorkspace-labelEdit-VersionFix: ./build/Installomator.sh citrixworkspace DEBUG=2
2023-05-03 14:47:17 : INFO : citrixworkspace : setting variable from argument DEBUG=2
2023-05-03 14:47:17 : REQ : citrixworkspace : ################## Start Installomator v. 10.4beta, date 2023-05-03
2023-05-03 14:47:17 : INFO : citrixworkspace : ################## Version: 10.4beta
2023-05-03 14:47:17 : INFO : citrixworkspace : ################## Date: 2023-05-03
2023-05-03 14:47:17 : INFO : citrixworkspace : ################## citrixworkspace
2023-05-03 14:47:17 : DEBUG : citrixworkspace : DEBUG mode 2 enabled.
2023-05-03 14:47:19 : DEBUG : citrixworkspace : name=Citrix Workspace
2023-05-03 14:47:19 : DEBUG : citrixworkspace : appName=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : type=pkgInDmg
2023-05-03 14:47:19 : DEBUG : citrixworkspace : archiveName=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : downloadURL=https://downloads.citrix.com/21799/CitrixWorkspaceApp.dmg?__gda__=exp=1683154038~acl=/*~hmac=8fdaebc8be8d4830367171894e011512a20853aa9dd8680d882b832d50225bd3
2023-05-03 14:47:19 : DEBUG : citrixworkspace : curlOptions=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : appNewVersion=23.04.0.36
2023-05-03 14:47:19 : DEBUG : citrixworkspace : appCustomVersion function: Not defined
2023-05-03 14:47:19 : DEBUG : citrixworkspace : versionKey=CitrixVersionString
2023-05-03 14:47:19 : DEBUG : citrixworkspace : packageID=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : pkgName=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : choiceChangesXML=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : expectedTeamID=S272Y5R93J
2023-05-03 14:47:19 : DEBUG : citrixworkspace : blockingProcesses=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : installerTool=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : CLIInstaller=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : CLIArguments=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : updateTool=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : updateToolArguments=
2023-05-03 14:47:19 : DEBUG : citrixworkspace : updateToolRunAsCurrentUser=
2023-05-03 14:47:19 : INFO : citrixworkspace : BLOCKING_PROCESS_ACTION=tell_user
2023-05-03 14:47:19 : INFO : citrixworkspace : NOTIFY=success
2023-05-03 14:47:19 : INFO : citrixworkspace : LOGGING=DEBUG
2023-05-03 14:47:19 : INFO : citrixworkspace : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2023-05-03 14:47:19 : INFO : citrixworkspace : Label type: pkgInDmg
2023-05-03 14:47:19 : INFO : citrixworkspace : archiveName: Citrix Workspace.dmg
2023-05-03 14:47:19 : INFO : citrixworkspace : no blocking processes defined, using Citrix Workspace as default
2023-05-03 14:47:19 : DEBUG : citrixworkspace : Changing directory to /var/folders/x6/ktgw5pg168l26d5k4sh49hm9mtb9zh/T/tmp.bhiopgTo
2023-05-03 14:47:19 : INFO : citrixworkspace : App(s) found: /Applications/Citrix Workspace.app
2023-05-03 14:47:19 : INFO : citrixworkspace : found app at /Applications/Citrix Workspace.app, version 23.04.0.36, on versionKey CitrixVersionString
2023-05-03 14:47:19 : INFO : citrixworkspace : appversion: 23.04.0.36
2023-05-03 14:47:19 : INFO : citrixworkspace : Latest version of Citrix Workspace is 23.04.0.36
2023-05-03 14:47:19 : INFO : citrixworkspace : There is no newer version available.
2023-05-03 14:47:19 : DEBUG : citrixworkspace : Deleting /var/folders/x6/ktgw5pg168l26d5k4sh49hm9mtb9zh/T/tmp.bhiopgTo
2023-05-03 14:47:19 : DEBUG : citrixworkspace : Debugging enabled, Deleting tmpDir output was:
/var/folders/x6/ktgw5pg168l26d5k4sh49hm9mtb9zh/T/tmp.bhiopgTo
2023-05-03 14:47:19 : INFO : citrixworkspace : App not closed, so no reopen.
2023-05-03 14:47:19 : REQ : citrixworkspace : No newer version.
2023-05-03 14:47:19 : REQ : citrixworkspace : ################## End Installomator, exit code 0

appNewVersion was no longer working. It seems Citrix removed the colon after "Version" at some point.

However, this output gave a result like "23.04.0.36 (2304)", which the ending parenthesis is a shortened version of the first two sets in the version number and was not needed, so added a cut for that.

Added versionKey as well to match that full version number, rather than using the shorter and slightly less precise triple version number.

Results when fully up to date version is already installed:

admin in ~/Documents/GitHub/Installomator on CitrixWorkspace-labelEdit-VersionFix:  ./build/Installomator.sh citrixworkspace DEBUG=2
2023-05-03 14:28:47 : INFO  : citrixworkspace : setting variable from argument DEBUG=2
2023-05-03 14:28:47 : REQ   : citrixworkspace : ################## Start Installomator v. 10.4beta, date 2023-05-03
2023-05-03 14:28:47 : INFO  : citrixworkspace : ################## Version: 10.4beta
2023-05-03 14:28:47 : INFO  : citrixworkspace : ################## Date: 2023-05-03
2023-05-03 14:28:47 : INFO  : citrixworkspace : ################## citrixworkspace
2023-05-03 14:28:47 : DEBUG : citrixworkspace : DEBUG mode 2 enabled.
2023-05-03 14:28:50 : DEBUG : citrixworkspace : name=Citrix Workspace
2023-05-03 14:28:50 : DEBUG : citrixworkspace : appName=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : type=pkgInDmg
2023-05-03 14:28:50 : DEBUG : citrixworkspace : archiveName=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : downloadURL=https://downloads.citrix.com/21799/CitrixWorkspaceApp.dmg?__gda__=exp=1683152928~acl=/*~hmac=425951550b395b085fffef5af7f15bd285cb1a5977f7fc8dee9d114bf5c88158
2023-05-03 14:28:50 : DEBUG : citrixworkspace : curlOptions=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : appNewVersion=23.04.0.36
2023-05-03 14:28:50 : DEBUG : citrixworkspace : appCustomVersion function: Not defined
2023-05-03 14:28:50 : DEBUG : citrixworkspace : versionKey=CitrixVersionString
2023-05-03 14:28:50 : DEBUG : citrixworkspace : packageID=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : pkgName=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : choiceChangesXML=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : expectedTeamID=S272Y5R93J
2023-05-03 14:28:50 : DEBUG : citrixworkspace : blockingProcesses=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : installerTool=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : CLIInstaller=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : CLIArguments=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : updateTool=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : updateToolArguments=
2023-05-03 14:28:50 : DEBUG : citrixworkspace : updateToolRunAsCurrentUser=
2023-05-03 14:28:50 : INFO  : citrixworkspace : BLOCKING_PROCESS_ACTION=tell_user
2023-05-03 14:28:50 : INFO  : citrixworkspace : NOTIFY=success
2023-05-03 14:28:50 : INFO  : citrixworkspace : LOGGING=DEBUG
2023-05-03 14:28:50 : INFO  : citrixworkspace : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2023-05-03 14:28:50 : INFO  : citrixworkspace : Label type: pkgInDmg
2023-05-03 14:28:50 : INFO  : citrixworkspace : archiveName: Citrix Workspace.dmg
2023-05-03 14:28:50 : INFO  : citrixworkspace : no blocking processes defined, using Citrix Workspace as default
2023-05-03 14:28:50 : DEBUG : citrixworkspace : Changing directory to /var/folders/x6/ktgw5pg168l26d5k4sh49hm9mtb9zh/T/tmp.QoGnFgCd
2023-05-03 14:28:50 : INFO  : citrixworkspace : App(s) found: /Applications/Citrix Workspace.app
2023-05-03 14:28:50 : INFO  : citrixworkspace : found app at /Applications/Citrix Workspace.app, version 23.04.0.36, on versionKey CitrixVersionString
2023-05-03 14:28:50 : INFO  : citrixworkspace : appversion: 23.04.0.36
2023-05-03 14:28:50 : INFO  : citrixworkspace : Latest version of Citrix Workspace is 23.04.0.36
2023-05-03 14:28:50 : INFO  : citrixworkspace : There is no newer version available.
2023-05-03 14:28:50 : DEBUG : citrixworkspace : Deleting /var/folders/x6/ktgw5pg168l26d5k4sh49hm9mtb9zh/T/tmp.QoGnFgCd
2023-05-03 14:28:50 : DEBUG : citrixworkspace : Debugging enabled, Deleting tmpDir output was:
/var/folders/x6/ktgw5pg168l26d5k4sh49hm9mtb9zh/T/tmp.QoGnFgCd
2023-05-03 14:28:50 : INFO  : citrixworkspace : App not closed, so no reopen.
2023-05-03 14:28:50 : REQ   : citrixworkspace : No newer version.
2023-05-03 14:28:50 : REQ   : citrixworkspace : ################## End Installomator, exit code 0
I learned how to use the cut command more better.
@scriptingosx scriptingosx added the application adds or improves an application label label May 26, 2023
@scriptingosx scriptingosx added this to the v10.4 milestone May 26, 2023
@scriptingosx
Copy link
Collaborator

Thank you!

@scriptingosx scriptingosx merged commit f8dead2 into Installomator:main May 26, 2023
@duderin0 duderin0 deleted the CitrixWorkspace-labelEdit-VersionFix branch May 26, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application adds or improves an application label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants