chore: update demo #799
Merged
chore: update demo #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think we should revise the approach to:
- separate out the code for internal and external navigator - most users will use one or the other, and having them both on the same file will make it harder to reason about.
- handle the toggling via a custom behavior - this will allow for the toggle UI to be rendered within Hyperview itself and also serve as a showcase for custom HV behaviors.
# Conflicts: # demo/src/HyperviewScreen.tsx # demo/src/Navigator.tsx
# Conflicts: # demo/src/HyperviewScreen.tsx # demo/src/Navigator.tsx
hgray-instawork
force-pushed
the
hardin/demo-update
branch
from
98b5cfb
to
dc2cea7
Compare
hgray-instawork
force-pushed
the
hardin/demo-update
branch
from
dc2cea7
to
251ffd6
Compare
hgray-instawork
force-pushed
the
hardin/demo-update
branch
from
f0f7457
to
0cf0481
Compare
hgray-instawork
force-pushed
the
hardin/demo-update
branch
from
0cf0481
to
b6e57a2
Compare
hgray-instawork
force-pushed
the
hardin/demo-update
branch
from
b6e57a2
to
fc0f37a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the demo to include example using
<navigator>HXML source.<navigator>syntaxExamples showing different functionality with 'legacy' and 'updated' navigation:
Asana: https://app.asana.com/0/1204008699308084/1206290261007827/f