add visualization for velocity fields #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2023 14:44
…s to the small velocities in the lid driven cavity example
|
Thank you, Patrick! I just saw this and merged your code. |
|
Your changes cause a heatmap bug that I don't quite know where it is. So I had to revert your pull request. |
|
Could you please share details of the bug with me, so that I can fix it later on? |
|
It seems the heatmap scale is incorrect. If you run the Natural Convection example in the Examples menu, you should see the screen is filled with white color pretty quickly. It should be like this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first of all thank you @charxie for this amazing tool. For the visualization of fluid mechanics heat maps of flow velocities seem more intuitive to me. Therefore, I implemented heat maps for the components of the velocity and its magnitude. Since the velocities in the lid driven cavity flow are much smaller than 1, I also added a scaling factor in ScalarDistributionRenderer to avoid all values being rounded to 0. Would there be a better solution for this?