fyi: changes to get energy2d working on Jdk12 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still not completely correct)
the conduction solver
JAXB (javax.xml.bind) deprecated in Java SE 9 and removed in 11. https://openjdk.java.net/jeps/320
com.apple.eawt.Application appears to have been removed in Java SE 8 similar functionality is now in java.awt.Desktop https://docs.oracle.com/javase/8/docs/api/java/awt/Desktop.html see: https://github.com/frostwire/frostwire/blob/master/desktop/src/com/limegroup/gnutella/gui/MacEventHandler.java for an interesting implementation that checks the version of java and uses conditional reflection to work with older and newer versions of java
stepheneb
commented
Oct 18, 2019
| }); | ||
| box.owner = frame; | ||
|
|
||
| // see: https://github.com/frostwire/frostwire/blob/master/desktop/src/com/limegroup/gnutella/gui/MacEventHandler.java |
There was a problem hiding this comment.
this is where the new code -- all the changes above are just indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to get energy2d working locally and am using jdk 12. I don't think this branch is really ready to merge to your master. There could be a more complete implementation that works on both older and newer javas -- but I thought the changes might be somewhat useful for you.