[WIP] Webapp data plotting #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayers24
reviewed
Apr 9, 2020
| @@ -0,0 +1,32 @@ | |||
| date,new_diagnoses,new_tests,new_deaths | |||
| 2020-03-01,1,24,0 | |||
There was a problem hiding this comment.
Do we need a calibration date field in the UI? Seem like right now, everything is based on n days from "start". Though, that could be a separate task if this is assuming the first entry is day 0
There was a problem hiding this comment.
@sayers24 yes, date rather than day index would be great!
|
@ckerr-IDM, you assigned me to this PR. What needs to be done here? |
|
@lgeorge-idm I think the plotting is OK, but at the moment it's just loading a dummy data file, which is causing the tests to break from a path issue -- so actually the part of this that still needs to be done is just #79 (just tagged you in that) |
deviozc
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP implementation of data plotting for the webapp. Still trying to tag you @deviozc, @sayers24
Closes #78, #79