Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local Platform Asset should be implemented via API or Docker socket #254

Closed
devclinton opened this issue Jul 25, 2019 · 1 comment
Closed

Local Platform Asset should be implemented via API or Docker socket #254

devclinton opened this issue Jul 25, 2019 · 1 comment
Assignees
@shchen-idmod
Labels
Local Platform Platform support
Milestone
Version 0.2

Comments

@devclinton
Copy link
Member

Currently we are sending files using a queue. This is not the most efficient use of redis or a good implementation for file upload. We should either

  • Add a Assets API
  • Or after the automatic docker setup, leveage py-docker for direct copying from host machine to the platform
@devclinton devclinton mentioned this issue Jul 25, 2019
Merged
mfisher-idmod pushed a commit that referenced this issue Jul 25, 2019
@shchen-idmod @mfisher-idmod
fix typo from previous checkin (#258)
1041aa4 
* fix failed testcase in test_python_simulation.py after dev fixed local runner bugs

* #223 - Temporary fix until we can properly address long-term solution. See  #254

* skip test_local_runner_cli testcase, it is really hard to get it right for parsing command line output

* typo in my previous checkin for skip decorator

* undo previous checkin
mfisher-idmod pushed a commit that referenced this issue Jul 26, 2019
@shchen-idmod @mfisher-idmod
update setup test script to include create docker network there in ca…
7901774 
…se it is not created (#259)

* fix failed testcase in test_python_simulation.py after dev fixed local runner bugs

* #223 - Temporary fix until we can properly address long-term solution. See  #254

* skip test_local_runner_cli testcase, it is really hard to get it right for parsing command line output

* typo in my previous checkin for skip decorator

* undo previous checkin

* update setup test script to include create docker network there in case it is not created
@devclinton devclinton mentioned this issue Aug 5, 2019
Merged
@shchen-idmod
Copy link
Collaborator

Verified from:
send_assets_for_experiment
send_assets_for_simulation
send_asset_to_docker
docker_operations.copy_to_container

@devclinton devclinton changed the title Local Platform Assest should be implemented via API or Docker socket Local Platform Asset should be implemented via API or Docker socket May 5, 2020
@devclinton devclinton added this to the Version 0.2 milestone May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shchen-idmod shchen-idmod

Labels
Local Platform Platform support
Projects
None yet
Milestone
Version 0.2
Development

No branches or pull requests
2 participants
@devclinton @shchen-idmod