Add user configs to gitignore #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonwang
reviewed
Jul 31, 2020
| @@ -14,5 +14,9 @@ report/ | |||
| .classpath | |||
| .project | |||
| .settings/ | |||
| conf/benchmarks.lst | |||
| conf/frameworks.lst | |||
| conf/hibench.conf | |||
There was a problem hiding this comment.
These files are already in git. Will that be a problem if someone wants to modify these files?
There was a problem hiding this comment.
When switching from one branch to another, you can still use the same config. Don't bother to resolve conflicts when switching branch. Just ignore the changes to config.
Also can avoid accidently commit user-modified configs to repo when you modify those files to benchmark something. You can still use git add -f to add if really need to commit the change.
There was a problem hiding this comment.
Just like hadoop.conf and spark.conf is user specific config, no need to commit. does it make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore configs