Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user configs to gitignore #632

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Add user configs to gitignore #632

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8047fb3
Add configs to gitignore
xwu99 Jul 21, 2020
ffd5525
Update .gitignore
xwu99 Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -14,5 +14,9 @@ report/
.classpath
.project
.settings/
conf/benchmarks.lst
conf/frameworks.lst
conf/hibench.conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are already in git. Will that be a problem if someone wants to modify these files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When switching from one branch to another, you can still use the same config. Don't bother to resolve conflicts when switching branch. Just ignore the changes to config.
Also can avoid accidently commit user-modified configs to repo when you modify those files to benchmark something. You can still use git add -f to add if really need to commit the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like hadoop.conf and spark.conf is user specific config, no need to commit. does it make sense?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

conf/hadoop.conf
conf/spark.conf
*.conf