This repository has been archived by the owner on Dec 11, 2022. It is now read-only.
Sync workers with global lock #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from NervanaSystems
…n tensorflow. speed up counter access and prevent not zero problem. 2, fix a sync bug. Clipped_ppo_agent for example if int(batch.size / self.ap.network_wrappers['main'].batch_size) is different between each workers, some worker will be in acting phase and other workers will be block in wait_for_all_workers_barrier
|
is this replacing #347? |
|
Yes for my prj |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare to my last pull request
1, use global sync lock instand of lock_counter and release_counter in tensorflow. speed up counter access and prevent not zero problem.
2, fix a sync bug. Clipped_ppo_agent for example
if int(batch.size / self.ap.network_wrappers['main'].batch_size) is different between each workers, some worker will be in acting phase and other workers will be block in wait_for_all_workers_barrier