Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitask ASE interface #224

Merged
merged 19 commits into from
May 28, 2024

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    c965377 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    aed05b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f3066d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a0cb969 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    907a403 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d542fa3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    db53652 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8c0ed40 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    17aa627 View commit details
    Browse the repository at this point in the history
  9. test: added unit tests for multi task aggregations

    Signed-off-by: Lee, Kin Long Kelvin <kin.long.kelvin.lee@intel.com>
    laserkelvin committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c982773 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e5cdb8e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    951c124 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3bcc446 View commit details
    Browse the repository at this point in the history
  13. test: updating test to make things work

    Signed-off-by: Lee, Kin Long Kelvin <kin.long.kelvin.lee@intel.com>
    laserkelvin committed May 17, 2024
    Configuration menu
    Copy the full SHA
    b0d161e View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. fix: correcting graph key retrieval from batch

    This isn't actually originally part of the PR scope, but apparently this typo never triggered as
    an issue until now!
    laserkelvin committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c7c25ff View commit details
    Browse the repository at this point in the history
  2. refactor: writing a dedicated method for multitask ase inference

    This substantially simplifies the workflow, albeit adds yet another method to
    multitask modules. The new method simply passes input data into the encoder,
    and maps it to every single subtask regardless, instead of requiring that
    the batch shares the dataset keys.
    laserkelvin committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4e87c5d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f8894c View commit details
    Browse the repository at this point in the history
  4. fix: patches input grad toggling based on incoming batch

    This adjusts the logic, albeit maybe inconsistent with the rest of multitask, where
    we check the incoming batch for dataset names at the top level to determine if it's
    a multidata batch, instead of relying on the model expectations.
    
    This fixes the ase calculate behavior, which would have been mismatched since the
    module is inherently multidata but the incoming batch is not.
    laserkelvin committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6e54dad View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. script: added pretrained example from multitask

    Signed-off-by: Lee, Kin Long Kelvin <kin.long.kelvin.lee@intel.com>
    laserkelvin committed May 28, 2024
    Configuration menu
    Copy the full SHA
    22c5f36 View commit details
    Browse the repository at this point in the history