This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Df reset index #656
Merged
Df reset index #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densmirn
reviewed
Mar 16, 2020
Comment on lines
1755
to
1756
| old_index = f'old_index' | ||
| func_lines += [f' old_index = {df}.index'] |
There was a problem hiding this comment.
Suggested change
| old_index = f'old_index' | |
| func_lines += [f' old_index = {df}.index'] | |
| old_index = 'old_index' | |
| func_lines += [f' {old_index} = {df}.index'] |
Rubtsowa
force-pushed
the
df_reset_index
branch
from
ba049f4
to
ee23d1f
Compare
|
|
||
| Limitations | ||
| ----------- | ||
| Reset the index of the DataFrame, and use the default one instead. |
There was a problem hiding this comment.
Why it doesn't say anything about supporting drop as literal values only?
| if not (col_fill == '' or isinstance(col_fill, types.Omitted)): | ||
| raise TypingError('{} Unsupported parameter col_fill. Given: {}'.format(func_name, col_fill)) | ||
|
|
||
| if not isinstance(drop, types.Literal): |
There was a problem hiding this comment.
Below implementation will only work with Boolean literals, so the check must be aligned.
kozlov-alexey
suggested changes
Mar 16, 2020
kozlov-alexey
approved these changes
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.