Remove Dashing, Eloquent, Foxy, L500 and SR300 support

[SamerKhshiboun]

Remove EOL models
Remove EOL distros
Remove unused files/code (specially related to fisheye and pose sensors)

[Nir-Az]

This is draft right?
Please update when it's ready for review.

[Arun-Prasad-V]

Hi @SamerKhshiboun ,

Since POSE stream is getting removed, does it make sense to remove the support for POSE sensor as well?
Reference line:

realsense-ros/realsense2_camera/src/rs_node_setup.cpp

Line 156 in 19bc683

else if (sensor.is<rs2::pose_sensor>())

[SamerKhshiboun]

sensor.isrs2::pose_sensor()

Fixed. Also deleted PoseProfile usage in other places

[Arun-Prasad-V]

sensor.isrs2::pose_sensor()

Fixed. Also deleted PoseProfile usage in other places

@SamerKhshiboun, It's still present in profile_manager.cpp

realsense-ros/realsense2_camera/src/profile_manager.cpp

Line 596 in 844210d

void PoseProfilesManager::registerProfileParameters(std::vector<stream_profile> all_profiles, std::function<void()> update_sensor_func)

[SamerKhshiboun]

sensor.isrs2::pose_sensor()

Fixed. Also deleted PoseProfile usage in other places

@SamerKhshiboun, It's still present in profile_manager.cpp

realsense-ros/realsense2_camera/src/profile_manager.cpp

Line 596 in 844210d

void PoseProfilesManager::registerProfileParameters(std::vector<stream_profile> all_profiles, std::function<void()> update_sensor_func)

Fixed, somehow it was missed in the git add command

[Nir-Az]

This used to be humble only, is it relevant to iron and rolling too?

[SamerKhshiboun]

did not understand the question.. can you elaborate more ? are you talking about pc2 or tf2_ros ?

[Nir-Az]

NVM I understand now :)

[Nir-Az]

@SamerKhshiboun please solve conflicts This branch has conflicts that must be resolved

[Arun-Prasad-V]

@SamerKhshiboun , Shall we remove the support of 'fisheye' sensor as well?

realsense-ros/realsense2_camera/src/rs_node_setup.cpp

Line 146 in 8656492

sensor.is<rs2::fisheye_sensor>())

realsense-ros/realsense2_camera/src/rs_node_setup.cpp

Line 332 in 8656492

bool is_video_sensor = (sensor->is<rs2::depth_sensor>() || sensor->is<rs2::color_sensor>() || sensor->is<rs2::fisheye_sensor>());

Also, in rs_launch.py

realsense-ros/realsense2_camera/launch/rs_launch.py

Line 47 in 8656492

{'name': 'enable_fisheye1', 'default': 'true', 'description': 'enable fisheye1 stream'},

realsense-ros/realsense2_description/urdf/_r430.urdf.xacro

Line 35 in 8656492

<xacro:property name="r430_cam_depth_to_fisheye_offset" value="0.042"/>

[SamerKhshiboun]

@SamerKhshiboun , Shall we remove the support of 'fisheye' sensor as well?

realsense-ros/realsense2_camera/src/rs_node_setup.cpp

Line 146 in 8656492

sensor.is<rs2::fisheye_sensor>())

realsense-ros/realsense2_camera/src/rs_node_setup.cpp

Line 332 in 8656492

bool is_video_sensor = (sensor->is<rs2::depth_sensor>() || sensor->is<rs2::color_sensor>() || sensor->is<rs2::fisheye_sensor>());

Also, in rs_launch.py

realsense-ros/realsense2_camera/launch/rs_launch.py

Line 47 in 8656492

{'name': 'enable_fisheye1', 'default': 'true', 'description': 'enable fisheye1 stream'},

realsense-ros/realsense2_description/urdf/_r430.urdf.xacro

Line 35 in 8656492

<xacro:property name="r430_cam_depth_to_fisheye_offset" value="0.042"/>

Fixed

[Nir-Az]

LGTM

[christian-rauch]

Is there a good reason to break the compatibility with foxy? Couldn't this be handled with #ifdefs like the other distributions? Could we alternatively at least introduce branches for distributions that are incompatible with the development branch? E.g. create a foxy branch for that last commit that still compiles on ROS foxy?