Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install specific numpy version to avoid errors in github actions #3130

Merged

Conversation

SamerKhshiboun
Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun commented Jun 16, 2024

Numpy has released a new version (2.0.0) before a couple of hours.. and it is failing our GitHub workflows in the testing section... because we have pip3 install numpy --upgrade which will install latest version..

image

@SamerKhshiboun
Copy link
Collaborator Author

SamerKhshiboun commented Jun 16, 2024

pre-release builds are expected to fail, since they are working with latest release of librealsense2 (2.55.1), but the current ROS needs the new API (calib config, etc..) of librealsense2/development (which passes in our CIs). So, we can merge even if these two jobs fail.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Jun 16, 2024

Not related, should we add pre realse for Jazzy as well?

@SamerKhshiboun
Copy link
Collaborator Author

Not related, should we add pre realse for Jazzy as well?

Yes, but they still doesn't support it.
https://github.com/ros-industrial/industrial_ci/blob/master/doc/index.rst#supported-ros-distributions

@SamerKhshiboun SamerKhshiboun merged commit 68473bd into IntelRealSense:ros2-development Jun 16, 2024
6 of 8 checks passed
@SamerKhshiboun SamerKhshiboun deleted the test1 branch June 18, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants