Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regex and remove forbidden windows characters #2012

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

Xaver106
Copy link
Contributor

Overview

Fixes #1872

Description

Just some refactoring of the regex

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@Xaver106 Xaver106 requested a review from a team as a code owner November 13, 2022 11:52
@github-actions github-actions bot added Bugfix This PR fixes a bug chore labels Nov 13, 2022
@intellectualsites-bot
Copy link
Member

To trigger a test build on Jenkins, this PR requires approval by a member of the @IntellectualSites/admins team. Comment with one of the commands below:

Command/Comment Description
ok to test Accept this PR for testing
test this please Trigger a one time test
retest this please Start a new build if the last one wasn't successful

@Xaver106 Xaver106 changed the title refactor: fix regex and remove forbidden windows characters fix regex and remove forbidden windows characters Nov 13, 2022
@Xaver106 Xaver106 marked this pull request as draft November 13, 2022 14:31
@Xaver106 Xaver106 marked this pull request as ready for review November 19, 2022 00:14
@NotMyFault
Copy link
Member

I have no access to a windows machine, could you provide an automatic test please, which verifies the desired result?

@Xaver106
Copy link
Contributor Author

Xaver106 commented Dec 3, 2022

I have no access to a windows machine, could you provide an automatic test please, which verifies the desired result?

This change is not Windows specific. It just modifies the filename verification to not allow windows speciific illegal characters.

@RedstoneFuture
Copy link
Member

grafik
grafik

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested

@NotMyFault NotMyFault merged commit 5e8bc5c into IntellectualSites:main Jan 15, 2023
@NotMyFault NotMyFault removed the chore label Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowed filenames can be problematic with windows
5 participants