Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: switch from adventure NBT to LinBus #2778

Merged
merged 8 commits into from
Jun 26, 2024
Merged

ref: switch from adventure NBT to LinBus #2778

merged 8 commits into from
Jun 26, 2024

Conversation

dordsor21
Copy link
Member

  • Hard replace all adventure NBT with linbus
  • Keep where we continue to use "deprecated" jnbt

@github-actions github-actions bot added the Feature This PR adds a new feature label Jun 14, 2024
exclude(dependency("org.apache.logging.log4j:log4j-api"))
exclude(dependency("com.google.code.findbugs:jsr305"))
exclude {
it.moduleGroup == "org.jetbrains.kotlin"
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still is also present in upstream, so just gonna leave it here :)

Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

# Conflicts:
#	worldedit-core/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/schematic/MinecraftStructure.java
@dordsor21 dordsor21 marked this pull request as ready for review June 14, 2024 18:35
@dordsor21 dordsor21 requested a review from a team as a code owner June 14, 2024 18:35
@dordsor21 dordsor21 changed the title Switch from adventure NBT to LinBus ref: sSwitch from adventure NBT to LinBus Jun 16, 2024
@dordsor21 dordsor21 changed the title ref: sSwitch from adventure NBT to LinBus ref: switch from adventure NBT to LinBus Jun 16, 2024
@NotMyFault NotMyFault requested a review from a team June 23, 2024 15:02
@PierreSchwang PierreSchwang mentioned this pull request Jun 23, 2024
4 tasks
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if the annotations could be removed, other than that looks good imo

Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though untested - but as long as it compiles?)

@dordsor21 dordsor21 merged commit ad5739e into main Jun 26, 2024
11 checks passed
@dordsor21 dordsor21 deleted the feat/lin-bus branch June 26, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature This PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants