-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: switch from adventure NBT to LinBus #2778
Conversation
dordsor21
commented
Jun 14, 2024
- Hard replace all adventure NBT with linbus
- Keep where we continue to use "deprecated" jnbt
exclude(dependency("org.apache.logging.log4j:log4j-api")) | ||
exclude(dependency("com.google.code.findbugs:jsr305")) | ||
exclude { | ||
it.moduleGroup == "org.jetbrains.kotlin" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still is also present in upstream, so just gonna leave it here :)
Please take a moment and address the merge conflicts of your pull request. Thanks! |
# Conflicts: # worldedit-core/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/schematic/MinecraftStructure.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if the annotations could be removed, other than that looks good imo
...ain/java/com/sk89q/worldedit/bukkit/adapter/ext.fawe/v1_20_R4/PaperweightDataConverters.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/FastSchematicReader.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (though untested - but as long as it compiles?)