-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow 0-width stroke width and 0-percent fill-opacity #73
Conversation
Regression I found out: Now the area is not clickable anymore, just the border, if the opacity is 0 no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My experience with Dynmap is limited. Is that something we can resolve on our end?
I've searched through dynmaps source as well, but I don't know either. I've created a separated issue as a feature request in dynmaps repo for that: webbukkit/dynmap#3637 |
@NotMyFault Found a workaround by setting the color to #FF000000 when the opacity is set to 0. The opacity is then set back to 1 and an 0-alpha channel is passed to the fill color. therefor the fill is still being added to the dom, but it's invisible. |
/rebase |
1eb11dc
to
8768008
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine so far
Overview
Based on an issue on discord
Description
Now a 0-width stroke width and 0-percent fill-opacity is possible + code reformat
Submitter Checklist
Maintainer checklist
Before the changes are marked as
Ready for merge
: