Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modrinth's list of supported versions #313

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Oct 1, 2023

FAWE supports 1.19.4 only, and given FAVS depends on FAWE, this list must be kept in sync.

build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Member

@Aurelien30000 Aurelien30000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry another thing I just realized 😅

1.17.1, 1.18.2, 1.19.4, 1.20, 1.20.1 and 1.20.2 - FastAsyncWorldEdit actively develops against and supports these versions.
This is from FAWE ci, is it up-to-date? If so, the lists should be updated accordingly. Either:

  • The first one misses 1.20 & 1.20.1.
  • The second one mentions erroneously 1.20 & 1.20.1.

@NotMyFault
Copy link
Member Author

Sorry another thing I just realized 😅

1.17.1, 1.18.2, 1.19.4, 1.20, 1.20.1 and 1.20.2 - FastAsyncWorldEdit actively develops against and supports these versions.
This is from FAWE ci, is it up-to-date? If so, the lists should be updated accordingly. Either:

  • The first one misses 1.20 & 1.20.1.
  • The second one mentions erroneously 1.20 & 1.20.1.

The former is the list of versions to choose from in the issue tracker, where it doesn't matter whether you use 1.20.2 or .1, due to the lack of impactful changes on FAVS.
The latter is the list of versions labeled as supported on modrinth, whereas dropping 1.20.1 and below is undesired.

@NotMyFault NotMyFault merged commit c6ba7a2 into main Oct 4, 2023
6 checks passed
@NotMyFault NotMyFault deleted the cleanup-list-of-versions branch October 4, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants