Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1.17.1 #37

Merged
merged 13 commits into from
Jul 23, 2021
Merged

Feature/1.17.1 #37

merged 13 commits into from
Jul 23, 2021

Conversation

NotMyFault
Copy link
Member

No description provided.

Aurelien30000 and others added 4 commits July 10, 2021 12:47
* Small cleanup, MC 1.17, Java 16 and repackaged FAWE.

* Small improvement

* Resolve some requests

* Re-add JDK 16 for actions

* Bump serverlib

* Global cleanup, delete async classes and most accesses to bukkit api, through our implementation.
Use editsession and WE alternatives instead.

* Bump major version => 2.0.0

* Remove all unused imports

* Replace ``#isSign`` method with a more reliable way

* Use Worldedit alternatives when possible, Bukkit api is now only used for basic commands, to let users using a common format.

* Remove Voxel undo and delegate work to FAWE.

* Don't parse json text for signs, because it returns an adventure component as String.

* Cleanup code:
- Add a few final fields
- Replace old code style prior Java 8
- Fix a minor performance issues

* Remove useless allocation previously used for undo work.

* Replace ``isSign`` method by ``DeprecationUtil#isSign``.
- Throw out permission node if player lacks them
- Other minor enhancements
* Small cleanup, MC 1.17, Java 16 and repackaged FAWE.

* Small improvement

* Resolve some requests

* Re-add JDK 16 for actions

* Bump serverlib

* Global cleanup, delete async classes and most accesses to bukkit api, through our implementation.
Use editsession and WE alternatives instead.

* Bump major version => 2.0.0

* Remove all unused imports

* Replace ``#isSign`` method with a more reliable way

* Use Worldedit alternatives when possible, Bukkit api is now only used for basic commands, to let users using a common format.

* Remove Voxel undo and delegate work to FAWE.

* Don't parse json text for signs, because it returns an adventure component as String.

* Cleanup code:
- Add a few final fields
- Replace old code style prior Java 8
- Fix a minor performance issues

* Remove useless allocation previously used for undo work.

* Replace ``isSign`` method by ``DeprecationUtil#isSign``.

* Fix #29

* Revert "Fix #29"

* Fix #29

* Minor refactor (unused imports cleaned)
@NotMyFault
Copy link
Member Author

@Aurelien30000 Do you also want to take a look at #8? You don't have to if you don't want to, you did already a good job at Favs, but letting me know allows me to coordinate this merge a bit better.

@Aurelien30000
Copy link
Member

Surely, should be easy to re-add!

Aurelien30000 and others added 2 commits July 11, 2021 11:26
* Small cleanup, MC 1.17, Java 16 and repackaged FAWE.

* Small improvement

* Resolve some requests

* Re-add JDK 16 for actions

* Bump serverlib

* Global cleanup, delete async classes and most accesses to bukkit api, through our implementation.
Use editsession and WE alternatives instead.

* Bump major version => 2.0.0

* Remove all unused imports

* Replace ``#isSign`` method with a more reliable way

* Use Worldedit alternatives when possible, Bukkit api is now only used for basic commands, to let users using a common format.

* Remove Voxel undo and delegate work to FAWE.

* Don't parse json text for signs, because it returns an adventure component as String.

* Cleanup code:
- Add a few final fields
- Replace old code style prior Java 8
- Fix a minor performance issues

* Remove useless allocation previously used for undo work.

* Replace ``isSign`` method by ``DeprecationUtil#isSign``.

* Fix #29

* Revert "Fix #29"

* Fix #29

* Minor refactor (unused imports cleaned)

* Fix #8
Re-add ErodeBlendBrush

* Remove unused ``undo-cache-size`` config option
@NotMyFault NotMyFault marked this pull request as ready for review July 11, 2021 10:57
@NotMyFault
Copy link
Member Author

NotMyFault commented Jul 11, 2021

Tested with Fawe version 1.17-49 on Paper build 99 (1.17.1) it appears I occasionally experience lighting issues:
/b eb & /b 5

Edit: Since we're using Fawe to process edits (?) this may need to be addressed there or handled differently here.

@Aurelien30000
Copy link
Member

Aurelien30000 commented Jul 11, 2021

A bit strange, I didn't experience any problem during my tests and progress (on Tuinity).
Note: Voxel itself doesn't interact with lighting.

@NotMyFault
Copy link
Member Author

NotMyFault commented Jul 11, 2021

Tuinity: https://streamable.com/xsilwh
Paper: https://streamable.com/s07khr

Since Fawe utilizes Starlight, I guess we handle things different here. However, using Tuinity I have have a shadow blink on every every edit. Not for a long time, but quite noticeable on the video linked. On Paper I didn't experience them so far but constant shadows occurring occasionally thru edits.
But on the other hand, I didn't experience (at least visually) shadow blinks on Paper.

Streamable
Watch "2021-07-11 13-54-21" on Streamable.
Streamable
Watch "2021-07-11 13-55-42" on Streamable.

@Aurelien30000
Copy link
Member

Humm, interesting, doesn't it seem to be a client visual issue? If you log out and then log again, do the shadows still appear?

@NotMyFault
Copy link
Member Author

Humm, interesting, doesn't it seem to be a client visual issue? If you log out and then log again, do the shadows still appear?

Packets are resend by then so no. They only affect the current login session.

@Aurelien30000
Copy link
Member

Aurelien30000 commented Jul 12, 2021

Hey again, tried FAVS wih friends, and it seems that the problem is directly related to FAWE.
Use a brush such as //brush sphere air 5, and apply the brush multiple times until issue occurs. So this issue seems related to the implementation of the light engine for spigot/paper.
image

@NotMyFault
Copy link
Member Author

I've lazily risen an issue on the appropriate repository handling described behavior.

- Handle /vc, /goto and /vi sanely
- Leave a note when /voxel_chunk was successful
@NotMyFault
Copy link
Member Author

NotMyFault commented Jul 13, 2021

I drafted a release a bit earlier, since the main functionalities appear to work. However, I found a bunch of other issues after testing all brushes (very tedious):

@Aurelien30000
Copy link
Member

  • /b regenerate_chunk applying on a chunk you previously selected via //chunk -> //set 0 solely sends the message without regening the chunk.

About this one, do you mean an empty chunk doesn't regenerate as expected, with full terrain?

@NotMyFault
Copy link
Member Author

  • /b regenerate_chunk applying on a chunk you previously selected via //chunk -> //set 0 solely sends the message without regening the chunk.

About this one, do you mean an empty chunk doesn't regenerate as expected, with full terrain?

Yes.

Aurelien30000 and others added 6 commits July 18, 2021 22:53
* Delete unused method.

* Fix and improve chunk regeneration.
Handle brush actions even if the target block is air **(only the layer above the void)**.

* Remove unused import.

* Follow .editorconfig rules, replace line endings from ``CRLF`` to ``LF``.

* Add warning about chunk regeneration processing time.

* Add configurable biome to regenerate chunk brush.
…ss at the same time. (#42)

- Replace use of a deprecated method to get legacy component serializer.
- Don't use String concatenation in a StringBuilder (BiomeBrush).
@NotMyFault NotMyFault merged commit 1e4d0ba into backward Jul 23, 2021
@NotMyFault NotMyFault deleted the feature/1.17.1 branch July 23, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants