Re-enable aigRewriting tests in CI. #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing sanitizer build is because of a misaligned memory access at https://github.com/IntelligentSoftwareSystems/Galois/blob/master/lonestar/eda/cpu/aigRewriting/algorithms/CutPool.cpp#L72. The fix isn't obvious to me yet. |
insertinterestingnamehere
force-pushed
the
aig
branch
from
86341db
to
a6b504f
Compare
|
@yishanlu if you get time at some point I'd appreciate confirmation that the fix here looks sane to you. I'll probably merge this very soon if the tests pass though to get it included in the release, but feel free to leave feedback even after this is merged. If the fix isn't quite right, we can backport additional changes. |
yishanlu
reviewed
Jun 13, 2020
insertinterestingnamehere
force-pushed
the
aig
branch
from
a6b504f
to
24f7d80
Compare
|
Okay, I've pushed a new fix that works locally. We'll see what the tests think. |
insertinterestingnamehere
force-pushed
the
aig
branch
from
24f7d80
to
7ad2b2e
Compare
|
Failure is unrelated. Merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.