Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow controls to override hotkey sequences #1708

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

petchema
Copy link
Collaborator

Disable hotkey sequences when controls with overridesHotkeySequences flag have the focus

Part of fix for issue #1707

Disable hotkey sequences when controls with overridesHotkeySequences
have the focus
@petchema
Copy link
Collaborator Author

petchema commented Feb 13, 2020

That could be made even a bit more flexible if controls could provide some keyboard events handler, returning true if they handled the event on their own; That way one could implement partial overrides.
I don't know if we'll require the extra flexibility, but it doesn't seem too difficult to implement.
On the other hand it may feel "too little" a change, given that most keyboard handling is mixed with other concerns in different Update() methods...
So for the moment my position is that this "simplest change that works" is sufficient.

@Interkarma Interkarma merged commit dacb44f into Interkarma:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants