Disable interactions during touch-range spell #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adying a Touch spell. Other spells already ignored interactions. All other interactions unaffected, and can be used while readying a touch-range spell.
|
I'm happy with that approach. Thanks so much Kab! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UX improvement for issue #2232.
I considered disabling all interactions except doors, "action" (ex: levers), ladders, and custom. Then, I decided that for most other interactions, if you're clicking on them, you probably meant to interact, not cast a spell on them.
Maybe loot markers might be accidentally misclicked in combat, and some may prefer disabling interactions with them while casting spells.
I decided not to, since players might be readying a spell from an auto-recast mod (ex: Hotkey Bar) and deliberately clicking a loot container.
So, in the end, I only disabled mobiles, since you're most likely intending to fight them. It was already dangerous to talk to villagers with a spell ready since it would go off even when you could successfully interact with them.