Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointer math correction #171

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Pointer math correction #171

merged 2 commits into from
Jan 5, 2021

Conversation

blakemcbride
Copy link
Contributor

No description provided.

waywardmonkeys
waywardmonkeys suggested changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was working on a similar patch ... but in that, I'd changed the types of len, and diff and such to size_t. Would you mind doing the same here?

@blakemcbride
Copy link
Contributor Author

Done

waywardmonkeys
waywardmonkeys approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nbriggs
nbriggs approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@nbriggs nbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbriggs nbriggs merged commit dd45960 into Interlisp:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

@nbriggs nbriggs nbriggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blakemcbride @waywardmonkeys @nbriggs