Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit 6f7ec059bc (Remove dead stores) breaks -DSTACKCHECK #162

Closed
nbriggs opened this issue Jan 21, 2021 · 1 comment · Fixed by Interlisp/maiko#266
Closed

commit 6f7ec059bc (Remove dead stores) breaks -DSTACKCHECK #162

nbriggs opened this issue Jan 21, 2021 · 1 comment · Fixed by Interlisp/maiko#266
Labels
bug Something isn't working

Comments

@nbriggs
Copy link
Contributor

nbriggs commented Jan 21, 2021

clang -m32 -std=gnu99 -fno-strict-aliasing -fwrapv -c -O2 -g  -DMACOSX -DOLD_CURSOR -DBYTESWAP -DLOGINT  -I/opt/X11/include -DXWINDOW -DNOPIXRECT -DRELEASE=351 -DSTACKCHECK -DFSBCHECK -DPCTRACE  -I../inc/ -I../include/ ../src/llstk.c  -o ../darwin.386-x/llstk.o
../src/llstk.c:340:7: error: expected expression
      StackWord *orig68k = scanptr68k;
      ^
../src/llstk.c:349:27: error: use of undeclared identifier 'orig68k'
        if (scanptr68k != orig68k) {
                          ^
../src/llstk.c:354:64: error: use of undeclared identifier 'orig68k'
        if (((Bframe *)scanptr68k)->ivar != StkOffset_from_68K(orig68k)) {
                                                               ^
3 errors generated.
make: *** [../darwin.386-x/llstk.o] Error 1
@nbriggs
Copy link
Contributor Author

nbriggs commented Jan 21, 2021

It leaves a declaration in the middle of code, not at the start of a { } block. Wrapping the code as default: { code } is a potential fix for this.

@nbriggs nbriggs added bug Something isn't working maiko labels Jan 21, 2021
waywardmonkeys added a commit to waywardmonkeys/maiko that referenced this issue Jan 21, 2021
In commit 6f7ec05, we removed
some dead stores. This broke compilation when `STACKCHECK` was
enabled.

Closes Interlisp/medley#162.
nbriggs pushed a commit to Interlisp/maiko that referenced this issue Jan 21, 2021
In commit 6f7ec05, we removed
some dead stores. This broke compilation when `STACKCHECK` was
enabled.

Closes Interlisp/medley#162.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant