IMINDEX: The displayfn of index image objects sets AFTERHARDCOPYFN to close the index file #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… close the index file Removes the need for advising the Tedit hardcopy function. This won't have an effect until a separate PR (after rmk7 is merged) that updates the hardcopy function.
|
doesn't seem to work when using HCFILES which uses
|
|
By not working, you mean that the index file still stays open?
Yes, it won’t do the close until the renaming PR is merged, and then another one that I am holding off in order to not get dependencies screwed up.
The problem is that the release TEDIT.FORMAT.HARDCOPY extracts the AFTERHARDCOPYFN before it starts to display the image objects, so the fact that the different image objects set the property has no effect.
This PR is independent of other changes (also includes the readtable fix), but by itself it doesn’t solve the closing problem.
But if “not working” means something else is broken, that’s something I should look at.
… On Apr 8, 2024, at 10:52 AM, Larry Masinter ***@***.***> wrote:
doesn't seem to work when using HCFILES which uses
image.png (view on web) <https://github.com/Interlisp/medley/assets/1116587/52cda3b7-ed46-487e-81fc-7aa88f30b02d>
—
Reply to this email directly, view it on GitHub <#1649 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJMYC3RH4NGDOWF5G3LY4LKPLAVCNFSM6AAAAABFZPK3G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGMZTCNJTGI>.
You are receiving this because you authored the thread.
|
rmkaplan
added a commit
that referenced
this pull request
Apr 19, 2024
so that it can be set by a display fn or boxfn along the way. This permits the fix to IRM indexing in PR #1649 to take effect (for HCFILES).
masinter
deleted the
rmk8--Make-sure-IMPTR-files-for-IRM-indexing-are-closed
branch
masinter
pushed a commit
that referenced
this pull request
Apr 30, 2024
so that it can be set by a display fn or boxfn along the way. This permits the fix to IRM indexing in PR #1649 to take effect (for HCFILES).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need for advising the Tedit hardcopy function. This won't have an effect until a separate PR (after rmk7 is merged) that updates the hardcopy function, but it is still compatible with currently released code.