Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (unitest, interleaved pp and other bugs): re-adapt unitest for isp and adapt interleaved pp for no flash_attention #52

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

li126com
Copy link
Collaborator

@li126com li126com commented Feb 22, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

  1. re-adapt weekly test for isp.
  2. adapt interleaved pp for no fa.
  3. fix bug in train.py for no fa.
  4. re-adapt test output for no fa.
  5. fix bug in build_unpack function.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@li126com li126com changed the title FEAT TEMP Fix (unitest and interleaved pp): re-adapt unitest for isp and adapt interleaved pp for no flash_attention Feb 22, 2024
@li126com li126com changed the title Fix (unitest and interleaved pp): re-adapt unitest for isp and adapt interleaved pp for no flash_attention Fix (unitest, interleaved pp and other bugs): re-adapt unitest for isp and adapt interleaved pp for no flash_attention Feb 23, 2024
@sunpengsdu sunpengsdu merged commit 20a2832 into InternLM:develop Mar 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants