Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(embedding.py): fix flash attn error of llama and internlm2 #83

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

sallyjunjun
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix flash attn error of llama and internlm2

Modification

remove float type transformation in no flash attention scenario
remove cu_seqlens and max_seqlen parameters in _single_eval function, because x is added one dimention before and the processing of packed qkv or packed single value in apply_rotary of version 2.1.0 can cause stuck error.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@huangting4201 huangting4201 changed the title fix flash attn error of llama and internlm2 fix(embedding.py): fix flash attn error of llama and internlm2 Mar 13, 2024
@huangting4201 huangting4201 self-requested a review March 13, 2024 10:47
@huangting4201 huangting4201 merged commit 7873d1c into develop Mar 14, 2024
18 checks passed
@sallyjunjun sallyjunjun deleted the fix-flash-attn branch July 29, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants