Support user-specified IMAGE_TOKEN position for deepseek-vl model #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
may provide a case so that @zhulinJulia24 can add it into TCs |
lvhan028
reviewed
May 23, 2024
lvhan028
reviewed
May 23, 2024
lvhan028
reviewed
May 23, 2024
lvhan028
reviewed
May 23, 2024
lvhan028
reviewed
May 24, 2024
| logger.error( | ||
| f'the number of {IMAGE_TOKEN} is not equal ' | ||
| f'to input images, {len(segs) - 1} vs {len(features)}') | ||
| features = features[:len(segs) - 1] |
There was a problem hiding this comment.
Is it possible that len(segs) > len(features)
AllentDan
reviewed
May 24, 2024
docs/zh_cn/inference/vl_pipeline.md
Outdated
| from lmdeploy.vl import load_image | ||
| from lmdeploy.vl.constants import IMAGE_TOKEN | ||
|
|
||
| pipe = pipeline('deepseek-ai/deepseek-vl-7b-chat') |
There was a problem hiding this comment.
Shall we try deepseek-ai/deepseek-vl-1.3b-chat instead as an example? It is smaller and can be downloaded faster.
| ```python | ||
| from lmdeploy import pipeline | ||
| from lmdeploy.vl import load_image | ||
| from lmdeploy.vl.constants import IMAGE_TOKEN |
There was a problem hiding this comment.
May notify users that is is actually '<IMAGE_TOKEN>' in comments or other forms. This is useful for api_server users.
lvhan028
approved these changes
May 24, 2024
lvhan028
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
for some models, the location of the image token is not restricted, in this case, the user should insert the image token manually.