Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 46: Bugfix adding necessary JSON-LD context elements #49

Merged

Conversation

sebbader-sap
Copy link
Contributor

This PR solves #46

I am completely aware that direct pushes to main are not allowed in general according to the contribution rules. As, however, the current state of these examples is simply wrong, I still purposely suggest it now.

Copy link
Member

@ssteinbuss ssteinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing obvious errors should be done as quick as possible

Copy link
Member

@ssteinbuss ssteinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing obvious wrong things, by adding missing elements.

@ssteinbuss ssteinbuss merged commit efaf241 into International-Data-Spaces-Association:main Sep 22, 2022
ssteinbuss added a commit that referenced this pull request Nov 10, 2022
* Issue 46: Bugfix adding necessary JSON-LD context elements (#49)

* Bugfix adding necessary JSON-LD context elements



Co-authored-by: Sebastian Steinbuss <23654606+ssteinbuss@users.noreply.github.com>

* Add specification input documents

* Remove uneccessary restrictions

* Add numbering

* Fix cardinality typo

* Add mapping section

Co-authored-by: sebbader-sap <107036549+sebbader-sap@users.noreply.github.com>
Co-authored-by: Jim Marino <jim.marino@gmail.com>
ssteinbuss added a commit that referenced this pull request Nov 10, 2022
* Issue 46: Bugfix adding necessary JSON-LD context elements (#49)

* Bugfix adding necessary JSON-LD context elements



Co-authored-by: Sebastian Steinbuss <23654606+ssteinbuss@users.noreply.github.com>

* First identity token draft

* Added mandatory claims section

Co-authored-by: sebbader-sap <107036549+sebbader-sap@users.noreply.github.com>
Co-authored-by: Michael Lux <michael.lux@aisec.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants