Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading Levels Not Validated #79

Closed
3 tasks done
PythooonUser opened this issue Sep 22, 2020 · 2 comments · Fixed by #144
Closed
3 tasks done

Loading Levels Not Validated #79

PythooonUser opened this issue Sep 22, 2020 · 2 comments · Fixed by #144
Labels
editor Editor related issue

Comments

@PythooonUser
Copy link
Contributor

PythooonUser commented Sep 22, 2020

loading-wrong

Summary

Any file can be loaded. Even ones that do not exist. They default to a new project layout. I would expect an error message in that case.

Work

  • Add ability to show error messages
  • Allow only valid level extensions to be loaded
  • Check if level could be loaded successfully
@joshuaskelly joshuaskelly added the editor Editor related issue label Sep 22, 2020
@PythooonUser PythooonUser changed the title [Editor|Windows] Loading Files Not Validated Loading Files Not Validated Sep 23, 2020
@PythooonUser
Copy link
Contributor Author

For this question to be answered we need to know more about the loading process itself. For .bin and .dat formats, especially .bin, are there any magic characters, specific bytes, data structures etc. that need to be valid? Or is it just waiting for errors to be thrown when trying to parse the level files?

For the legacy .png format, are there any validations we can use? Like colors, size etc.?

@PythooonUser PythooonUser changed the title Loading Files Not Validated Loading Levels Not Validated Sep 28, 2020
@PythooonUser
Copy link
Contributor Author

Started looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Editor related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants