Tidy up "New calculateMinTxFee function"

[newhoggy]

Changelog

- description: |
    Re-implement `evaluateTransactionFee` using ledger's `calcMinFeeTx`
    The `evaluateTransactionFee` takes an additional `utxo` parameter and no longer takes `byronwitcount`.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This improves the accurate of the evaluateTransactionFee function.

See IntersectMBO/cardano-cli#534 (comment)

Impact on cardano-cli

cardano-cli uses evaluateTransactionFee here.

This usage does not have utxo in scope which will be required after this change is introduced.

A possible solution is to query for the utxo like this.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[newhoggy]

CC @gitmachtl @GeorgeFlerovsky @lehins

[carbolymer]

cc: @dnadales

[dnadales]

Is this only the UTXO associated with the inputs in the parameter TxBody era?

We should probably add a comment specifying this.

[newhoggy]

Comment updated.

[dnadales]

"Satisfying" or "validating"?

[Jimbo4350]

👍

[Jimbo4350]

This can be made more clear with something like the following: "The number of Shelley key witnesses needed for native scripts or additional redundant key witnesses". Currently it reads like the total number of key witnesses for the transaction.