governance vote view: use --output-format, like other commands, instead of --yaml

[smelc]

Note

I will squash before merging but wanted to keep the commits separate in case there are comments, to better control history for myself

Changelog

- description: |
    governance vote view: use `--output-format`, like other commands, instead of `--yaml`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #516

On the way, I shared some code in the parsers; because code duplication is what brought this issue in the first place I think.

How to trust this PR

Inspect the diff in golden files

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[Jimbo4350]

you can use a comma instead of <>

[smelc]

Ah true that, because of the leading mconcat. Good catch 👍

Change done

[Jimbo4350]

Same, you can use a comma.

[smelc]

Change done 👍

[Jimbo4350]

A flag here would be nicer imo: --yaml | --json. We can add flags if we ever want to include more format options. What does the parsing error look like for --output-format STRING vs specifying a misspelled flag?

[smelc]

Sounds good, I will do that in a follow-up PR rn, because it's a bigger change, because it affects multiple commands.

[Jimbo4350]

If we use flags, we can avoid _ completely