proposal: disambiguate binary data from text data

[smelc]

Changelog

- description: |
    Introduce newtype to disambiguate binary data from text data
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #568

I couldn't find other usages of ProposalText for binary data, so I think this is all there is to do to fix 568

How to trust this PR

It is really harmless

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• Self-reviewed the diff

[carbolymer]

That's funny, neither ProposalText or ProposalBinary are used in reading file:

cardano-cli/cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/Hash.hs

Line 46 in 8def78a

case toHash of

I guess the next step would be to make use of those newtypes. 😄

[Jimbo4350]

They should be defined as type level tags.

[smelc]

They should be defined as type level tags.

Done in #683

[Jimbo4350]

👍

[Jimbo4350]

They should be defined as type level tags.