Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert-cardano-address-key: support DRep and CC keys #691

Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Apr 4, 2024

Changelog

- description: |
    convert-cardano-address-key: support DRep and CC keys
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #687

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/convert-cardano-address-key-cc-drep-support branch 5 times, most recently from 37b1b31 to 728e5ec Compare April 4, 2024 15:29
@smelc smelc marked this pull request as ready for review April 4, 2024 15:29
@disassembler disassembler added this pull request to the merge queue Apr 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2024
@disassembler disassembler added this pull request to the merge queue Apr 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2024
@disassembler disassembler added this pull request to the merge queue Apr 4, 2024
@disassembler disassembler removed this pull request from the merge queue due to a manual request Apr 4, 2024
@disassembler disassembler force-pushed the smelc/convert-cardano-address-key-cc-drep-support branch from 728e5ec to 06aaea4 Compare April 4, 2024 20:47
@disassembler disassembler added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 8b6ddfe Apr 4, 2024
16 checks passed
@disassembler disassembler deleted the smelc/convert-cardano-address-key-cc-drep-support branch April 4, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert-cardano-address-key doesn't have flags for conway CIP-105 key types
3 participants