Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction metadata golden test #713

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Apr 11, 2024

Changelog

- description: |
    Add transaction metadata golden test
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Useful for tracking transaction metadata format changes. For example in: IntersectMBO/cardano-api#517

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/test/add-metadata-golden-test branch from c0dfae2 to bf226f3 Compare April 11, 2024 13:55
@carbolymer carbolymer force-pushed the mgalazyn/test/add-metadata-golden-test branch from bf226f3 to 59d2eed Compare April 11, 2024 13:56
@carbolymer carbolymer marked this pull request as ready for review April 11, 2024 13:57
@carbolymer carbolymer added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 0758a14 Apr 11, 2024
18 checks passed
@carbolymer carbolymer deleted the mgalazyn/test/add-metadata-golden-test branch April 11, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants